diff options
| author | Christian Engelmayer <cengelma@gmx.at> | 2014-04-21 20:47:05 +0200 |
|---|---|---|
| committer | Herbert Xu <herbert@gondor.apana.org.au> | 2014-04-28 12:21:18 +0200 |
| commit | 6af1f93e2a0192fb1efbe82a5fef53d71cbe218b (patch) | |
| tree | 4a293e06c5bfc608fcaea36108ae2edf3feecb2e /crypto | |
| parent | crypto: tcrypt - Fix potential leak in test_aead_speed() if crypto_alloc_aead... (diff) | |
| download | linux-6af1f93e2a0192fb1efbe82a5fef53d71cbe218b.tar.xz linux-6af1f93e2a0192fb1efbe82a5fef53d71cbe218b.zip | |
crypto: tcrypt - Fix leak of struct aead_request in test_aead_speed()
Fix leakage of memory for struct aead_request that is allocated via
aead_request_alloc() but not released via aead_request_free().
Reported by Coverity - CID 1163869.
Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
Reviewed-by: Marek Vasut <marex@denx.de>
Acked-by: Tim Chen <tim.c.chen@linux.intel.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'crypto')
| -rw-r--r-- | crypto/tcrypt.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c index 18491552b83a..09c93ff216e4 100644 --- a/crypto/tcrypt.c +++ b/crypto/tcrypt.c @@ -320,7 +320,7 @@ static void test_aead_speed(const char *algo, int enc, unsigned int sec, if (!req) { pr_err("alg: aead: Failed to allocate request for %s\n", algo); - goto out; + goto out_noreq; } i = 0; @@ -390,6 +390,8 @@ static void test_aead_speed(const char *algo, int enc, unsigned int sec, } while (*keysize); out: + aead_request_free(req); +out_noreq: crypto_free_aead(tfm); out_notfm: kfree(sg); |