diff options
| author | Horia Geantă <horia.geanta@nxp.com> | 2017-07-07 15:57:06 +0200 |
|---|---|---|
| committer | Herbert Xu <herbert@gondor.apana.org.au> | 2017-07-12 12:38:04 +0200 |
| commit | 7459e1d25ffefa2b1be799477fcc1f6c62f6cec7 (patch) | |
| tree | 68becac06891beeb0520d957b1b50dc28bcd9281 /crypto | |
| parent | crypto: sha1-ssse3 - Disable avx2 (diff) | |
| download | linux-7459e1d25ffefa2b1be799477fcc1f6c62f6cec7.tar.xz linux-7459e1d25ffefa2b1be799477fcc1f6c62f6cec7.zip | |
crypto: caam - fix signals handling
Driver does not properly handle the case when signals interrupt
wait_for_completion_interruptible():
-it does not check for return value
-completion structure is allocated on stack; in case a signal interrupts
the sleep, it will go out of scope, causing the worker thread
(caam_jr_dequeue) to fail when it accesses it
wait_for_completion_interruptible() is replaced with uninterruptable
wait_for_completion().
We choose to block all signals while waiting for I/O (device executing
the split key generation job descriptor) since the alternative - in
order to have a deterministic device state - would be to flush the job
ring (aborting *all* in-progress jobs).
Cc: <stable@vger.kernel.org>
Fixes: 045e36780f115 ("crypto: caam - ahash hmac support")
Fixes: 4c1ec1f930154 ("crypto: caam - refactor key_gen, sg")
Signed-off-by: Horia Geantă <horia.geanta@nxp.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'crypto')
0 files changed, 0 insertions, 0 deletions