summaryrefslogtreecommitdiffstats
path: root/crypto
diff options
context:
space:
mode:
authorRoman Smirnov <r.smirnov@omp.ru>2024-04-01 14:22:58 +0200
committerHerbert Xu <herbert@gondor.apana.org.au>2024-04-12 09:07:51 +0200
commitea32d5474be1fc4e92e19b0e1a827ffff772eb22 (patch)
tree91988051e1eccf38555bf5a3223f05854eda5121 /crypto
parentcrypto: ecc - remove checks in crypto_ecdh_shared_secret() and ecc_make_pub_k... (diff)
downloadlinux-ea32d5474be1fc4e92e19b0e1a827ffff772eb22.tar.xz
linux-ea32d5474be1fc4e92e19b0e1a827ffff772eb22.zip
crypto: algboss - remove NULL check in cryptomgr_schedule_probe()
The for loop will be executed at least once, so i > 0. If the loop is interrupted before i is incremented (e.g., when checking len for NULL), i will not be checked. Found by Linux Verification Center (linuxtesting.org) with Svace. Signed-off-by: Roman Smirnov <r.smirnov@omp.ru> Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'crypto')
-rw-r--r--crypto/algboss.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/crypto/algboss.c b/crypto/algboss.c
index 0de1e6697949..1aa5f306998a 100644
--- a/crypto/algboss.c
+++ b/crypto/algboss.c
@@ -138,9 +138,6 @@ static int cryptomgr_schedule_probe(struct crypto_larval *larval)
goto err_free_param;
}
- if (!i)
- goto err_free_param;
-
param->tb[i + 1] = NULL;
param->type.attr.rta_len = sizeof(param->type);