diff options
author | Mingming Cao <cmm@us.ibm.com> | 2006-12-07 05:38:18 +0100 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.osdl.org> | 2006-12-07 17:39:39 +0100 |
commit | 2bd94bd79e5bfa217714f78e5d6d7b6517ca546f (patch) | |
tree | 825e9764b6e62492fddd8f14694b09a44e0ecb0a /drivers/Makefile | |
parent | [PATCH] hotplug CPU: clean up hotcpu_notifier() use (diff) | |
download | linux-2bd94bd79e5bfa217714f78e5d6d7b6517ca546f.tar.xz linux-2bd94bd79e5bfa217714f78e5d6d7b6517ca546f.zip |
[PATCH] ext3: fix reservation extension
Hugh Dickins wrote:
> Not found anything relevant, but I keep noticing these lines
> in ext2_try_to_allocate_with_rsv(), ext3 and ext4 similar:
>
> } else if (grp_goal > 0 &&
> (my_rsv->rsv_end - grp_goal + 1) < *count)
> try_to_extend_reservation(my_rsv, sb,
> *count-my_rsv->rsv_end + grp_goal - 1);
>
> They're wrong, a no-op in most groups, aren't they? rsv_end is an
> absolute block number, whereas grp_goal is group-relative, so the
> calculation ought to bring in group_first_block? Or I'm confused.
>
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Cc: "linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>
Cc: Hugh Dickins <hugh@veritas.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to '')
0 files changed, 0 insertions, 0 deletions