diff options
author | Thomas Renninger <trenn@suse.de> | 2010-10-01 10:53:59 +0200 |
---|---|---|
committer | Len Brown <len.brown@intel.com> | 2010-10-01 21:36:39 +0200 |
commit | 2b2ae7c7f8e25043793042eb9df88aa875b4cff8 (patch) | |
tree | 83daed7afd0d0b060219f8aff97a645dbf8027bc /drivers/acpi/button.c | |
parent | Linux 2.6.36-rc6 (diff) | |
download | linux-2b2ae7c7f8e25043793042eb9df88aa875b4cff8.tar.xz linux-2b2ae7c7f8e25043793042eb9df88aa875b4cff8.zip |
ACPI: Do not export hid/modalias sysfs file for ACPI objects without a HID
Boot and compile tested.
The fact that pnp.ids can now be empty needs testing on some
further machines, though.
This should handle a "modprobe is wrongly called by udev" issue:
https://bugzilla.kernel.org/show_bug.cgi?id=19162
Modaliase files in
/sys/devices/LNXSYSTM:00/
went down from 113 to 71 on my tested system.
This is a sysfs change, but userspace must already be able to handle it.
Also do not fill up pnp.ids list with a "struct hid"
entry. This comment:
* This generic ID isn't useful for driver binding, but it provides
* the useful property that "every acpi_device has an ID."
is still half way true:
Best you never touch pnp.ids list directly or make sure it can be empty,
instead use:
char *acpi_device_hid()
which always returns a value ("device" as a dummy if the object
has no hid).
Signed-off-by: Thomas Renninger <trenn@suse.de>
CC: Zhang Rui <rui.zhang@intel.com>
CC: kay.sievers@vrfy.org
CC: Bjorn Helgaas <bjorn.helgaas@hp.com>
Signed-off-by: Len Brown <len.brown@intel.com>
Diffstat (limited to 'drivers/acpi/button.c')
0 files changed, 0 insertions, 0 deletions