diff options
| author | Armin Wolf <W_Armin@gmx.de> | 2023-03-24 21:26:27 +0100 |
|---|---|---|
| committer | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2023-03-30 19:01:05 +0200 |
| commit | e5b492c6bb900fcf9722e05f4a10924410e170c1 (patch) | |
| tree | 83ef7fc1f47b921d0443a3890adc74fd80ffcc2f /drivers/acpi/ec.c | |
| parent | ACPI: EC: Limit explicit removal of query handlers to custom query handlers (diff) | |
| download | linux-e5b492c6bb900fcf9722e05f4a10924410e170c1.tar.xz linux-e5b492c6bb900fcf9722e05f4a10924410e170c1.zip | |
ACPI: EC: Fix oops when removing custom query handlers
When removing custom query handlers, the handler might still
be used inside the EC query workqueue, causing a kernel oops
if the module holding the callback function was already unloaded.
Fix this by flushing the EC query workqueue when removing
custom query handlers.
Tested on a Acer Travelmate 4002WLMi
Signed-off-by: Armin Wolf <W_Armin@gmx.de>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'drivers/acpi/ec.c')
| -rw-r--r-- | drivers/acpi/ec.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c index 5ef72287d1be..928899ab9502 100644 --- a/drivers/acpi/ec.c +++ b/drivers/acpi/ec.c @@ -1133,6 +1133,7 @@ static void acpi_ec_remove_query_handlers(struct acpi_ec *ec, void acpi_ec_remove_query_handler(struct acpi_ec *ec, u8 query_bit) { acpi_ec_remove_query_handlers(ec, false, query_bit); + flush_workqueue(ec_query_wq); } EXPORT_SYMBOL_GPL(acpi_ec_remove_query_handler); |