diff options
| author | Rafael J. Wysocki <rjw@sisk.pl> | 2010-11-25 00:05:17 +0100 |
|---|---|---|
| committer | Len Brown <len.brown@intel.com> | 2011-01-12 10:48:43 +0100 |
| commit | 32a00d274e877eab3ea7ab196b75c9be5170d25e (patch) | |
| tree | 0b7a515e8b2328e8cf8b22794cdf81ab19838b5d /drivers/acpi/power.c | |
| parent | Linux 2.6.37 (diff) | |
| download | linux-32a00d274e877eab3ea7ab196b75c9be5170d25e.tar.xz linux-32a00d274e877eab3ea7ab196b75c9be5170d25e.zip | |
ACPI / PM: Prevent acpi_power_get_inferred_state() from making changes
acpi_power_get_inferred_state() should not update
device->power.state behind the back of its caller, so make it return
the state via a pointer instead.
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Signed-off-by: Len Brown <len.brown@intel.com>
Diffstat (limited to 'drivers/acpi/power.c')
| -rw-r--r-- | drivers/acpi/power.c | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/drivers/acpi/power.c b/drivers/acpi/power.c index 4c9c2fb5d98f..9bd1b6044b55 100644 --- a/drivers/acpi/power.c +++ b/drivers/acpi/power.c @@ -423,19 +423,16 @@ int acpi_disable_wakeup_device_power(struct acpi_device *dev) Device Power Management -------------------------------------------------------------------------- */ -int acpi_power_get_inferred_state(struct acpi_device *device) +int acpi_power_get_inferred_state(struct acpi_device *device, int *state) { int result = 0; struct acpi_handle_list *list = NULL; int list_state = 0; int i = 0; - - if (!device) + if (!device || !state) return -EINVAL; - device->power.state = ACPI_STATE_UNKNOWN; - /* * We know a device's inferred power state when all the resources * required for a given D-state are 'on'. @@ -450,13 +447,12 @@ int acpi_power_get_inferred_state(struct acpi_device *device) return result; if (list_state == ACPI_POWER_RESOURCE_STATE_ON) { - device->power.state = i; + *state = i; return 0; } } - device->power.state = ACPI_STATE_D3; - + *state = ACPI_STATE_D3; return 0; } |