diff options
author | Wenwen Wang <wang6495@umn.edu> | 2019-04-20 03:49:29 +0200 |
---|---|---|
committer | Paul Moore <paul@paul-moore.com> | 2019-04-22 17:22:03 +0200 |
commit | 70c4cf17e445264453bc5323db3e50aa0ac9e81f (patch) | |
tree | d4ac7a73d1e877e885a1b9310654c21a55235c85 /drivers/acpi/sbshc.h | |
parent | ntp: Audit NTP parameters adjustment (diff) | |
download | linux-70c4cf17e445264453bc5323db3e50aa0ac9e81f.tar.xz linux-70c4cf17e445264453bc5323db3e50aa0ac9e81f.zip |
audit: fix a memory leak bug
In audit_rule_change(), audit_data_to_entry() is firstly invoked to
translate the payload data to the kernel's rule representation. In
audit_data_to_entry(), depending on the audit field type, an audit tree may
be created in audit_make_tree(), which eventually invokes kmalloc() to
allocate the tree. Since this tree is a temporary tree, it will be then
freed in the following execution, e.g., audit_add_rule() if the message
type is AUDIT_ADD_RULE or audit_del_rule() if the message type is
AUDIT_DEL_RULE. However, if the message type is neither AUDIT_ADD_RULE nor
AUDIT_DEL_RULE, i.e., the default case of the switch statement, this
temporary tree is not freed.
To fix this issue, only allocate the tree when the type is AUDIT_ADD_RULE
or AUDIT_DEL_RULE.
Signed-off-by: Wenwen Wang <wang6495@umn.edu>
Reviewed-by: Richard Guy Briggs <rgb@redhat.com>
Signed-off-by: Paul Moore <paul@paul-moore.com>
Diffstat (limited to 'drivers/acpi/sbshc.h')
0 files changed, 0 insertions, 0 deletions