summaryrefslogtreecommitdiffstats
path: root/drivers/acpi
diff options
context:
space:
mode:
authorLenny Szubowicz <lszubowi@redhat.com>2018-12-19 17:50:52 +0100
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>2018-12-20 21:35:45 +0100
commit98cff8b23ed1c763a029ee81ea300df0d153d07d (patch)
treeab49e11cec4b7c632ba391b5fced4295d169386b /drivers/acpi
parentACPI, APEI, EINJ: Change to use DEFINE_SHOW_ATTRIBUTE macro (diff)
downloadlinux-98cff8b23ed1c763a029ee81ea300df0d153d07d.tar.xz
linux-98cff8b23ed1c763a029ee81ea300df0d153d07d.zip
ACPI/APEI: Clear GHES block_status before panic()
In __ghes_panic() clear the block status in the APEI generic error status block for that generic hardware error source before calling panic() to prevent a second panic() in the crash kernel for exactly the same fatal error. Otherwise ghes_probe(), running in the crash kernel, would see an unhandled error in the APEI generic error status block and panic again, thereby precluding any crash dump. Signed-off-by: Lenny Szubowicz <lszubowi@redhat.com> Signed-off-by: David Arcari <darcari@redhat.com> Tested-by: Tyler Baicar <baicar.tyler@gmail.com> Acked-by: Borislav Petkov <bp@suse.de> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'drivers/acpi')
-rw-r--r--drivers/acpi/apei/ghes.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
index 02c6fd9caff7..f008ba7c9ced 100644
--- a/drivers/acpi/apei/ghes.c
+++ b/drivers/acpi/apei/ghes.c
@@ -691,6 +691,8 @@ static void __ghes_panic(struct ghes *ghes)
{
__ghes_print_estatus(KERN_EMERG, ghes->generic, ghes->estatus);
+ ghes_clear_estatus(ghes);
+
/* reboot to log the error! */
if (!panic_timeout)
panic_timeout = ghes_panic_timeout;