diff options
author | David Vrabel <david.vrabel@citrix.com> | 2015-01-13 17:42:42 +0100 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2015-01-13 23:22:11 +0100 |
commit | 900e183301b54f8ca17a86d9835e9569090d182a (patch) | |
tree | 222e2526f5b5f7891a7f1e3bc71deffe3f0ccdd0 /drivers/amba | |
parent | drivers: net: cpsw: fix multicast flush in dual emac mode (diff) | |
download | linux-900e183301b54f8ca17a86d9835e9569090d182a.tar.xz linux-900e183301b54f8ca17a86d9835e9569090d182a.zip |
xen-netfront: use different locks for Rx and Tx stats
In netfront the Rx and Tx path are independent and use different
locks. The Tx lock is held with hard irqs disabled, but Rx lock is
held with only BH disabled. Since both sides use the same stats lock,
a deadlock may occur.
[ INFO: possible irq lock inversion dependency detected ]
3.16.2 #16 Not tainted
---------------------------------------------------------
swapper/0/0 just changed the state of lock:
(&(&queue->tx_lock)->rlock){-.....}, at: [<c03adec8>]
xennet_tx_interrupt+0x14/0x34
but this lock took another, HARDIRQ-unsafe lock in the past:
(&stat->syncp.seq#2){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this:
Possible interrupt unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&stat->syncp.seq#2);
local_irq_disable();
lock(&(&queue->tx_lock)->rlock);
lock(&stat->syncp.seq#2);
<Interrupt>
lock(&(&queue->tx_lock)->rlock);
Using separate locks for the Rx and Tx stats fixes this deadlock.
Reported-by: Dmitry Piotrovsky <piotrovskydmitry@gmail.com>
Signed-off-by: David Vrabel <david.vrabel@citrix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/amba')
0 files changed, 0 insertions, 0 deletions