diff options
| author | Todd Kjos <tkjos@android.com> | 2017-08-09 00:48:36 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-08-23 03:48:22 +0200 |
| commit | 4f9adc8f91ba996374cd9487ecd1180fa99b9438 (patch) | |
| tree | 611f4e1f3eb11d3dfccd1e2a98862060b5f9243e /drivers/android | |
| parent | binder: free memory on error (diff) | |
| download | linux-4f9adc8f91ba996374cd9487ecd1180fa99b9438.tar.xz linux-4f9adc8f91ba996374cd9487ecd1180fa99b9438.zip | |
binder: fix incorrect cmd to binder_stat_br
commit 26549d177410 ("binder: guarantee txn complete / errors delivered
in-order") passed the locally declared and undefined cmd
to binder_stat_br() which results in a bogus cmd field in a trace
event and BR stats are incremented incorrectly.
Change to use e->cmd which has been initialized.
Signed-off-by: Todd Kjos <tkjos@google.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: 26549d177410 ("binder: guarantee txn complete / errors delivered in-order")
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/android')
| -rw-r--r-- | drivers/android/binder.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/android/binder.c b/drivers/android/binder.c index b366dc9e8217..947eb7056fa7 100644 --- a/drivers/android/binder.c +++ b/drivers/android/binder.c @@ -3619,7 +3619,7 @@ retry: e->cmd = BR_OK; ptr += sizeof(uint32_t); - binder_stat_br(proc, thread, cmd); + binder_stat_br(proc, thread, e->cmd); } break; case BINDER_WORK_TRANSACTION_COMPLETE: { binder_inner_proc_unlock(proc); |