diff options
author | Alexey Dobriyan <adobriyan@gmail.com> | 2007-03-24 13:58:12 +0100 |
---|---|---|
committer | Wim Van Sebroeck <wim@iguana.be> | 2007-03-26 22:26:11 +0200 |
commit | fb8f7ba077b5c665432082ab205bcd2cb01f6a3c (patch) | |
tree | 13a956eb9a1723bd3d5463230acbfc6513f3b034 /drivers/ata/ata_piix.c | |
parent | [WATCHDOG] add support for the w83627thf chipset. (diff) | |
download | linux-fb8f7ba077b5c665432082ab205bcd2cb01f6a3c.tar.xz linux-fb8f7ba077b5c665432082ab205bcd2cb01f6a3c.zip |
[WATCHDOG] Semi-typical watchdog bug re early misc_register()
It seems that some watchdog drivers are doing following mistake:
rv = misc_register();
if (rv < 0)
return rv;
rv = request_region();
if (rv < 0) {
misc_deregister();
return rv;
}
But, right after misc_register() returns, misc device can be opened and
ioctls interacting with hardware issued, and driver can do outb() to
port it doesn't own yet, because request_region() is still pending.
Here is my patch, compile-tested only.
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
Diffstat (limited to 'drivers/ata/ata_piix.c')
0 files changed, 0 insertions, 0 deletions