diff options
| author | Tejun Heo <tj@kernel.org> | 2015-08-03 17:41:33 +0200 |
|---|---|---|
| committer | Tejun Heo <tj@kernel.org> | 2015-08-03 17:41:33 +0200 |
| commit | fe16d4f202c59a560533a223bc6375739ee30944 (patch) | |
| tree | 56bb840c5826263d17373d9b1bcbbbcccd8173b2 /drivers/ata/libata-eh.c | |
| parent | ata: ahci_brcmstb: Fix warnings with CONFIG_PM_SLEEP=n (diff) | |
| download | linux-fe16d4f202c59a560533a223bc6375739ee30944.tar.xz linux-fe16d4f202c59a560533a223bc6375739ee30944.zip | |
Revert "libata-eh: Set 'information' field for autosense"
This reverts commit a1524f226a02aa6edebd90ae0752e97cfd78b159.
As implemented, ACS-4 sense reporting for ATA devices bypasses error
diagnosis and handling in libata degrading EH behavior significantly.
Revert the related changes for now.
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Hannes Reinecke <hare@suse.de>
Cc: stable@vger.kernel.org #v4.1+
Diffstat (limited to 'drivers/ata/libata-eh.c')
| -rw-r--r-- | drivers/ata/libata-eh.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c index 7465031a893c..af08d32af4e0 100644 --- a/drivers/ata/libata-eh.c +++ b/drivers/ata/libata-eh.c @@ -1864,7 +1864,6 @@ void ata_eh_analyze_ncq_error(struct ata_link *link) ata_dev_dbg(dev, "NCQ Autosense %02x/%02x/%02x\n", sense_key, asc, ascq); ata_scsi_set_sense(qc->scsicmd, sense_key, asc, ascq); - ata_scsi_set_sense_information(qc->scsicmd, &qc->result_tf); qc->flags |= ATA_QCFLAG_SENSE_VALID; } @@ -1907,8 +1906,6 @@ static unsigned int ata_eh_analyze_tf(struct ata_queued_cmd *qc, tmp = ata_eh_request_sense(qc, qc->scsicmd); if (tmp) qc->err_mask |= tmp; - else - ata_scsi_set_sense_information(qc->scsicmd, tf); } else { ata_dev_warn(qc->dev, "sense data available but port frozen\n"); } |