diff options
| author | Kees Cook <keescook@chromium.org> | 2020-06-03 23:18:09 +0200 |
|---|---|---|
| committer | Kees Cook <keescook@chromium.org> | 2020-07-16 21:32:26 +0200 |
| commit | d8b44b58a7073b4d74b3394131eb449e8469396b (patch) | |
| tree | 9fdce9d5ec46cb3e84b18881182402317cfef747 /drivers/ata/libata-scsi.c | |
| parent | mm/debug_vm_pgtable: Remove uninitialized_var() usage (diff) | |
| download | linux-d8b44b58a7073b4d74b3394131eb449e8469396b.tar.xz linux-d8b44b58a7073b4d74b3394131eb449e8469396b.zip | |
checkpatch: Remove awareness of uninitialized_var() macro
Using uninitialized_var() is dangerous as it papers over real bugs[1]
(or can in the future), and suppresses unrelated compiler warnings
(e.g. "unused variable"). If the compiler thinks it is uninitialized,
either simply initialize the variable or make compiler changes.
In preparation for removing[2] the[3] macro[4], partially revert
commit 16b7f3c89907 ("checkpatch: avoid warning about uninitialized_var()")
and remove all remaining mentions of uninitialized_var().
[1] https://lore.kernel.org/lkml/20200603174714.192027-1-glider@google.com/
[2] https://lore.kernel.org/lkml/CA+55aFw+Vbj0i=1TGqCR5vQkCzWJ0QxK6CernOU6eedsudAixw@mail.gmail.com/
[3] https://lore.kernel.org/lkml/CA+55aFwgbgqhbp1fkxvRKEpzyR5J8n1vKT1VZdz9knmPuXhOeg@mail.gmail.com/
[4] https://lore.kernel.org/lkml/CA+55aFz2500WfbKXAx8s67wrm9=yVJu65TpLgN_ybYNv0VEOKA@mail.gmail.com/
Signed-off-by: Kees Cook <keescook@chromium.org>
Diffstat (limited to 'drivers/ata/libata-scsi.c')
0 files changed, 0 insertions, 0 deletions