diff options
| author | Marcin Slusarz <marcin.slusarz@gmail.com> | 2008-11-02 22:18:52 +0100 |
|---|---|---|
| committer | Jeff Garzik <jgarzik@redhat.com> | 2008-11-04 07:08:06 +0100 |
| commit | 554d491de112a378b4d1a705bb93b58bcd444a70 (patch) | |
| tree | 020ac5c2f15cfd04b53c2798eb19d9e00be1413e /drivers/ata/sata_via.c | |
| parent | sata_promise: add ATA engine reset to reset ops (diff) | |
| download | linux-554d491de112a378b4d1a705bb93b58bcd444a70.tar.xz linux-554d491de112a378b4d1a705bb93b58bcd444a70.zip | |
sata_via: restore vt*_prepare_host error handling
commit b9d5b89b487517cbd4cb4702da829e07ef9e4432 (sata_via: fix support
for 5287) accidently (?) removed vt*_prepare_host error handling - restore it
catched by gcc:
drivers/ata/sata_via.c: In function 'svia_init_one':
drivers/ata/sata_via.c:567: warning: 'host' may be used uninitialized in this function
Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
Cc: Tejun Heo <tj@kernel.org>
Cc: Joseph Chan <JosephChan@via.com.tw>
Cc: Jeff Garzik <jgarzik@redhat.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Diffstat (limited to 'drivers/ata/sata_via.c')
| -rw-r--r-- | drivers/ata/sata_via.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/ata/sata_via.c b/drivers/ata/sata_via.c index 62367fe4d5dc..c18935f0bda2 100644 --- a/drivers/ata/sata_via.c +++ b/drivers/ata/sata_via.c @@ -602,8 +602,10 @@ static int svia_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) rc = vt8251_prepare_host(pdev, &host); break; default: - return -EINVAL; + rc = -EINVAL; } + if (rc) + return rc; svia_configure(pdev); |