diff options
| author | Tejun Heo <htejun@gmail.com> | 2007-10-31 02:17:06 +0100 |
|---|---|---|
| committer | Jeff Garzik <jeff@garzik.org> | 2007-11-03 13:47:27 +0100 |
| commit | db64bcf387aae6c7afad122a529d7d0513d3c5db (patch) | |
| tree | 62fcd54c4f1d1c03d0360e37dc7f198a8ab8ae33 /drivers/ata | |
| parent | libata: consider errors not associated with commands for speed down (diff) | |
| download | linux-db64bcf387aae6c7afad122a529d7d0513d3c5db.tar.xz linux-db64bcf387aae6c7afad122a529d7d0513d3c5db.zip | |
libata: request PHY speed configuration on SControl access failure
In sata_set_spd_needed(), if SControl read failed, it returned 0 and
skipped PHY speed configuration. However, if SControl access fails,
it's far more logical to request PHY speed configuration. Reverse the
logic.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
Diffstat (limited to 'drivers/ata')
| -rw-r--r-- | drivers/ata/libata-core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 24b3bd63621f..3a1ec4e715ed 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c @@ -2784,7 +2784,7 @@ int sata_set_spd_needed(struct ata_link *link) u32 scontrol; if (sata_scr_read(link, SCR_CONTROL, &scontrol)) - return 0; + return 1; return __sata_set_spd_needed(link, &scontrol); } |