summaryrefslogtreecommitdiffstats
path: root/drivers/ata
diff options
context:
space:
mode:
authorYangtao Li <tiny.windzz@gmail.com>2018-11-22 13:39:24 +0100
committerJens Axboe <axboe@kernel.dk>2018-12-21 15:12:25 +0100
commit745d51dc8a29e00e9ba14e090aa3c8a41e7221d9 (patch)
treea17aa7fe10d0c9bda6a255bb776880b55a651edf /drivers/ata
parentsata_rcar: fix deferred probing (diff)
downloadlinux-745d51dc8a29e00e9ba14e090aa3c8a41e7221d9.tar.xz
linux-745d51dc8a29e00e9ba14e090aa3c8a41e7221d9.zip
ata: pata_macio: add of_node_put()
of_find_node_by_path() acquires a reference to the node returned by it and that reference needs to be dropped by its caller. This place doesn't do that, so fix it. Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers/ata')
-rw-r--r--drivers/ata/pata_macio.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/ata/pata_macio.c b/drivers/ata/pata_macio.c
index 9588e685d994..8cc9c429ad95 100644
--- a/drivers/ata/pata_macio.c
+++ b/drivers/ata/pata_macio.c
@@ -483,6 +483,8 @@ static int pata_macio_cable_detect(struct ata_port *ap)
struct device_node *root = of_find_node_by_path("/");
const char *model = of_get_property(root, "model", NULL);
+ of_node_put(root);
+
if (cable && !strncmp(cable, "80-", 3)) {
/* Some drives fail to detect 80c cable in PowerBook
* These machine use proprietary short IDE cable