summaryrefslogtreecommitdiffstats
path: root/drivers/ata
diff options
context:
space:
mode:
authorOndrej Zary <linux@zary.sk>2023-02-18 23:01:26 +0100
committerDamien Le Moal <damien.lemoal@opensource.wdc.com>2023-03-23 02:29:25 +0100
commitec6e7a51d9eb1cd27840f7d8d5d05328631c9a15 (patch)
tree0beca74013e9b7612cf85bbfc71518181ceb274c /drivers/ata
parentata: pata_parport: Introduce module_pata_parport_driver macro (diff)
downloadlinux-ec6e7a51d9eb1cd27840f7d8d5d05328631c9a15.tar.xz
linux-ec6e7a51d9eb1cd27840f7d8d5d05328631c9a15.zip
ata: pata_parport: remove devtype from struct pi_adapter
Only bpck driver uses devtype but it never gets set in pata_parport. Remove it. As most bpck devices are CD-ROMs, always run the code that depends on devtype == PI_PCD. Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru> Signed-off-by: Ondrej Zary <linux@zary.sk> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Diffstat (limited to 'drivers/ata')
-rw-r--r--drivers/ata/pata_parport/bpck.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/ata/pata_parport/bpck.c b/drivers/ata/pata_parport/bpck.c
index b9174cf8863c..96386a10c22f 100644
--- a/drivers/ata/pata_parport/bpck.c
+++ b/drivers/ata/pata_parport/bpck.c
@@ -241,14 +241,14 @@ static void bpck_connect ( PIA *pi )
WR(5,8);
- if (pi->devtype == PI_PCD) {
+/* if (pi->devtype == PI_PCD) { possibly wrong, purpose unknown */
WR(0x46,0x10); /* fiddle with ESS logic ??? */
WR(0x4c,0x38);
WR(0x4d,0x88);
WR(0x46,0xa0);
WR(0x41,0);
WR(0x4e,8);
- }
+/* }*/
}
static void bpck_disconnect ( PIA *pi )