diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2018-05-29 11:13:24 +0200 |
|---|---|---|
| committer | Tejun Heo <tj@kernel.org> | 2018-05-29 15:48:54 +0200 |
| commit | 18c9a99bce2a57dfd7e881658703b5d7469cc7b9 (patch) | |
| tree | 10f0fe3c1ce08f8ea08aa24636d6da0eddf3ccff /drivers/ata | |
| parent | ahci: Add PCI ID for Cannon Lake PCH-LP AHCI (diff) | |
| download | linux-18c9a99bce2a57dfd7e881658703b5d7469cc7b9.tar.xz linux-18c9a99bce2a57dfd7e881658703b5d7469cc7b9.zip | |
libata: zpodd: small read overflow in eject_tray()
We read from the cdb[] buffer in ata_exec_internal_sg(). It has to be
ATAPI_CDB_LEN (16) bytes long, but this buffer is only 12 bytes.
Fixes: 213342053db5 ("libata: handle power transition of ODD")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: stable@vger.kernel.org
Diffstat (limited to 'drivers/ata')
| -rw-r--r-- | drivers/ata/libata-zpodd.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/ata/libata-zpodd.c b/drivers/ata/libata-zpodd.c index de4ddd0e8550..b3ed8f9953a8 100644 --- a/drivers/ata/libata-zpodd.c +++ b/drivers/ata/libata-zpodd.c @@ -35,7 +35,7 @@ struct zpodd { static int eject_tray(struct ata_device *dev) { struct ata_taskfile tf; - static const char cdb[] = { GPCMD_START_STOP_UNIT, + static const char cdb[ATAPI_CDB_LEN] = { GPCMD_START_STOP_UNIT, 0, 0, 0, 0x02, /* LoEj */ 0, 0, 0, 0, 0, 0, 0, |