diff options
| author | David Woodhouse <dwmw2@infradead.org> | 2013-03-29 12:54:55 +0100 |
|---|---|---|
| committer | Jeff Garzik <jgarzik@redhat.com> | 2013-04-04 01:45:57 +0200 |
| commit | 8e725c7f8a60feaa88edacd4dee2c754d5ae7706 (patch) | |
| tree | c1cec8594972926936365b124a10a5ce05233265 /drivers/ata | |
| parent | ata_piix: Fix DVD not dectected at some Haswell platforms (diff) | |
| download | linux-8e725c7f8a60feaa88edacd4dee2c754d5ae7706.tar.xz linux-8e725c7f8a60feaa88edacd4dee2c754d5ae7706.zip | |
libata: fix DMA to stack in reading devslp_timing parameters
Commit 803739d25c2343da6d2f95eebdcbc08bf67097d4 ("[libata] replace
sata_settings with devslp_timing"), which was also Cc: stable, used a
stack buffer to receive data from ata_read_log_page(), which triggers
the following warning:
ahci 0000:00:1f.2: DMA-API: device driver maps memory fromstack [addr=ffff880140469948]
Fix this by using ap->sector_buf instead of a stack buffer.
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
Cc: stable@kernel.org
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Diffstat (limited to 'drivers/ata')
| -rw-r--r-- | drivers/ata/libata-core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 0075944a64dc..63c743baf920 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c @@ -2329,7 +2329,7 @@ int ata_dev_configure(struct ata_device *dev) * from SATA Settings page of Identify Device Data Log. */ if (ata_id_has_devslp(dev->id)) { - u8 sata_setting[ATA_SECT_SIZE]; + u8 *sata_setting = ap->sector_buf; int i, j; dev->flags |= ATA_DFLAG_DEVSLP; |