diff options
| author | roel kluin <roel.kluin@gmail.com> | 2009-10-23 08:09:55 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2009-10-29 09:39:55 +0100 |
| commit | e0c5567d06ecf7777b6c46f4d933a0a6e09a44f3 (patch) | |
| tree | e7ce3e8b2a082919d3f928fb7dad0d8eac8edcfd /drivers/atm/he.c | |
| parent | net: Cleanup redundant tests on unsigned (diff) | |
| download | linux-e0c5567d06ecf7777b6c46f4d933a0a6e09a44f3.tar.xz linux-e0c5567d06ecf7777b6c46f4d933a0a6e09a44f3.zip | |
atm: Cleanup redundant tests on unsigned
The variables are unsigned so the `< 0' test always fails, the
other part of the test catches wrapped values.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/atm/he.c')
| -rw-r--r-- | drivers/atm/he.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/atm/he.c b/drivers/atm/he.c index 70667033a568..e90665876c47 100644 --- a/drivers/atm/he.c +++ b/drivers/atm/he.c @@ -2739,7 +2739,7 @@ he_ioctl(struct atm_dev *atm_dev, unsigned int cmd, void __user *arg) spin_lock_irqsave(&he_dev->global_lock, flags); switch (reg.type) { case HE_REGTYPE_PCI: - if (reg.addr < 0 || reg.addr >= HE_REGMAP_SIZE) { + if (reg.addr >= HE_REGMAP_SIZE) { err = -EINVAL; break; } |