diff options
| author | Ivan Bornyakov <brnkv.i1@gmail.com> | 2018-05-25 19:49:52 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-05-29 15:59:53 +0200 |
| commit | f9c6442a8f0b1dde9e755eb4ff6fa22bcce4eabc (patch) | |
| tree | 4aaae2913584f690008cebd6b7594322e60872f7 /drivers/atm/zatm.c | |
| parent | net: netsec: reduce DMA mask to 40 bits (diff) | |
| download | linux-f9c6442a8f0b1dde9e755eb4ff6fa22bcce4eabc.tar.xz linux-f9c6442a8f0b1dde9e755eb4ff6fa22bcce4eabc.zip | |
atm: zatm: fix memcmp casting
memcmp() returns int, but eprom_try_esi() cast it to unsigned char. One
can lose significant bits and get 0 from non-0 value returned by the
memcmp().
Signed-off-by: Ivan Bornyakov <brnkv.i1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
| -rw-r--r-- | drivers/atm/zatm.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/atm/zatm.c b/drivers/atm/zatm.c index 9c9a22958717..a8d2eb0ceb8d 100644 --- a/drivers/atm/zatm.c +++ b/drivers/atm/zatm.c @@ -1151,8 +1151,8 @@ static void eprom_get_byte(struct zatm_dev *zatm_dev, unsigned char *byte, } -static unsigned char eprom_try_esi(struct atm_dev *dev, unsigned short cmd, - int offset, int swap) +static int eprom_try_esi(struct atm_dev *dev, unsigned short cmd, int offset, + int swap) { unsigned char buf[ZEPROM_SIZE]; struct zatm_dev *zatm_dev; |