diff options
| author | Alan Stern <stern@rowland.harvard.edu> | 2008-02-29 17:50:22 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2008-03-04 23:47:05 +0100 |
| commit | 1b3cbec1dcb6747b587b40335f5de1d9e035063c (patch) | |
| tree | 7e24a74ac0c8082581335c764b184e0ae027804e /drivers/base | |
| parent | PM: Do not acquire device semaphores upfront during suspend (diff) | |
| download | linux-1b3cbec1dcb6747b587b40335f5de1d9e035063c.tar.xz linux-1b3cbec1dcb6747b587b40335f5de1d9e035063c.zip | |
PM: fix new mutex-locking bug in the PM core
This patch (as1041) fixes a bug introduced by the
acquire-all-device-semaphores reversion. The error pathway of
dpm_suspend() fails to reacquire a mutex it should be holding.
Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/base')
| -rw-r--r-- | drivers/base/power/main.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c index b0c16f6fc186..d887d5cb5bef 100644 --- a/drivers/base/power/main.c +++ b/drivers/base/power/main.c @@ -428,6 +428,7 @@ static int dpm_suspend(pm_message_t state) mutex_unlock(&dpm_list_mtx); error = suspend_device(dev, state); + mutex_lock(&dpm_list_mtx); if (error) { printk(KERN_ERR "Could not suspend device %s: " "error %d%s\n", @@ -438,7 +439,6 @@ static int dpm_suspend(pm_message_t state) "")); break; } - mutex_lock(&dpm_list_mtx); if (!list_empty(&dev->power.entry)) list_move(&dev->power.entry, &dpm_off); } |