diff options
| author | Xiubo Li <lixiubo@cmss.chinamobile.com> | 2015-12-11 04:23:20 +0100 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2015-12-12 23:37:06 +0100 |
| commit | 167f7066a637332b463adf3b87b2af1c1031591a (patch) | |
| tree | 64037f281d013f9bc362d82c432c0a5bc0aca25e /drivers/base | |
| parent | regmap: cache: Add warning info for the cache check (diff) | |
| download | linux-167f7066a637332b463adf3b87b2af1c1031591a.tar.xz linux-167f7066a637332b463adf3b87b2af1c1031591a.zip | |
regmap: cache: Move the num_reg_defaults check as early as possible
If the register defaults are provided by the driver without the
number by mistake, it should just return an error with one promotion.
This should be as early as possible, then there is no need to verify
the register defaults' stride and the other code followed.
Signed-off-by: Xiubo Li <lixiubo@cmss.chinamobile.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/base')
| -rw-r--r-- | drivers/base/regmap/regcache.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/drivers/base/regmap/regcache.c b/drivers/base/regmap/regcache.c index 9436a0d4cf71..60aeaad7fb69 100644 --- a/drivers/base/regmap/regcache.c +++ b/drivers/base/regmap/regcache.c @@ -109,6 +109,12 @@ int regcache_init(struct regmap *map, const struct regmap_config *config) return 0; } + if (config->reg_defaults && !config->num_reg_defaults) { + dev_err(map->dev, + "Register defaults are set without the number!\n"); + return -EINVAL; + } + for (i = 0; i < config->num_reg_defaults; i++) if (config->reg_defaults[i].reg % map->reg_stride) return -EINVAL; @@ -142,8 +148,6 @@ int regcache_init(struct regmap *map, const struct regmap_config *config) * a copy of it. */ if (config->reg_defaults) { - if (!map->num_reg_defaults) - return -EINVAL; tmp_buf = kmemdup(config->reg_defaults, map->num_reg_defaults * sizeof(struct reg_default), GFP_KERNEL); if (!tmp_buf) |