summaryrefslogtreecommitdiffstats
path: root/drivers/base
diff options
context:
space:
mode:
authorJustin Stitt <justinstitt@google.com>2024-04-29 22:50:30 +0200
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>2024-04-30 12:59:30 +0200
commit7b831bd3cf322fdacd07f321d6d7297914ed79bc (patch)
tree9fd3ca93a7a72b395c55dc188381a71f6a5b0850 /drivers/base
parentMerge back earlier system-wide PM changes for 6.10. (diff)
downloadlinux-7b831bd3cf322fdacd07f321d6d7297914ed79bc.tar.xz
linux-7b831bd3cf322fdacd07f321d6d7297914ed79bc.zip
PM: hibernate: replace deprecated strncpy() with strscpy()
strncpy() is deprecated for use on NUL-terminated destination strings [1] and as such we should prefer more robust and less ambiguous string interfaces. This kernel config option is simply assigned with the resume_file buffer. It should be NUL-terminated but not necessarily NUL-padded as per its further usage with other string apis: | static int __init find_resume_device(void) | { | if (!strlen(resume_file)) | return -ENOENT; | | pm_pr_dbg("Checking hibernation image partition %s\n", resume_file); Use strscpy() [2] as it guarantees NUL-termination on the destination buffer. Specifically, use the new 2-argument version of strscpy() introduced in Commit e6584c3964f2f ("string: Allow 2-argument strscpy()"). Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1] Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2] Link: https://github.com/KSPP/linux/issues/90 Signed-off-by: Justin Stitt <justinstitt@google.com> Reviewed-by: Kees Cook <keescook@chromium.org> Reviewed-by: Dhruva Gole <d-gole@ti.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'drivers/base')
0 files changed, 0 insertions, 0 deletions