diff options
| author | Longlong Xia <xialonglong1@huawei.com> | 2023-02-10 10:54:43 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-02-10 11:26:36 +0100 |
| commit | 90a9d5ff225267b3376f73c19f21174e3b6d7746 (patch) | |
| tree | 3c0b77cfcbd1cf13cbada9c9ed3f1f53c0af6354 /drivers/base | |
| parent | driver core: add error handling for devtmpfs_create_node() (diff) | |
| download | linux-90a9d5ff225267b3376f73c19f21174e3b6d7746.tar.xz linux-90a9d5ff225267b3376f73c19f21174e3b6d7746.zip | |
devtmpfs: add debug info to handle()
Because handle() is the core function for processing devtmpfs requests,
Let's add some debug info in handle() to help users know why failed.
Signed-off-by: Longlong Xia <xialonglong1@huawei.com>
Link: https://lore.kernel.org/r/20230210095444.4067307-3-xialonglong1@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/base')
| -rw-r--r-- | drivers/base/devtmpfs.c | 12 |
1 files changed, 10 insertions, 2 deletions
diff --git a/drivers/base/devtmpfs.c b/drivers/base/devtmpfs.c index 95ebc18ded50..f273bccd5494 100644 --- a/drivers/base/devtmpfs.c +++ b/drivers/base/devtmpfs.c @@ -389,10 +389,18 @@ static __initdata DECLARE_COMPLETION(setup_done); static int handle(const char *name, umode_t mode, kuid_t uid, kgid_t gid, struct device *dev) { + int ret; + if (mode) - return handle_create(name, mode, uid, gid, dev); + ret = handle_create(name, mode, uid, gid, dev); else - return handle_remove(name, dev); + ret = handle_remove(name, dev); + + if (ret) + dev_err(dev, "failed to %s %s, ret = %d\n", + mode ? "create" : "remove", name, ret); + + return ret; } static void __noreturn devtmpfs_work_loop(void) |