summaryrefslogtreecommitdiffstats
path: root/drivers/bcma/driver_chipcommon_sflash.c
diff options
context:
space:
mode:
authorBrian Norris <computersforpeace@gmail.com>2016-02-26 11:50:28 +0100
committerBrian Norris <computersforpeace@gmail.com>2016-04-04 09:07:57 +0200
commit5651d6aaf489d1db48c253cf884b40214e91c2c5 (patch)
treeda4bc73c1d32f47829974ab4fce280d99f6e28bb /drivers/bcma/driver_chipcommon_sflash.c
parentmtd: avoid stack overflow in MTD CFI code (diff)
downloadlinux-5651d6aaf489d1db48c253cf884b40214e91c2c5.tar.xz
linux-5651d6aaf489d1db48c253cf884b40214e91c2c5.zip
mtd: bcm47xxsflash: use ioremap_cache() instead of KSEG0ADDR()
Using KSEG0ADDR makes code highly MIPS dependent and not portable. Thanks to the fix a68f376 ("MIPS: io.h: Define `ioremap_cache'") we can use ioremap_cache which is generic and supported on MIPS as well now. KSEG0ADDR was translating 0x1c000000 into 0x9c000000. With ioremap_cache we use MIPS's __ioremap (and then remap_area_pages). This results in different address (e.g. 0xc0080000) but it still should be cached as expected and it was successfully tested with BCM47186B0. Other than that drivers/bcma/driver_chipcommon_sflash.c nicely setups a struct resource for access window, but we wren't using it. Use it now and drop duplicated info. Signed-off-by: Brian Norris <computersforpeace@gmail.com> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
Diffstat (limited to 'drivers/bcma/driver_chipcommon_sflash.c')
-rw-r--r--drivers/bcma/driver_chipcommon_sflash.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/bcma/driver_chipcommon_sflash.c b/drivers/bcma/driver_chipcommon_sflash.c
index 04d706ca5f43..35b13a08ca3e 100644
--- a/drivers/bcma/driver_chipcommon_sflash.c
+++ b/drivers/bcma/driver_chipcommon_sflash.c
@@ -146,7 +146,6 @@ int bcma_sflash_init(struct bcma_drv_cc *cc)
return -ENOTSUPP;
}
- sflash->window = BCMA_SOC_FLASH2;
sflash->blocksize = e->blocksize;
sflash->numblocks = e->numblocks;
sflash->size = sflash->blocksize * sflash->numblocks;