diff options
| author | Lars Ellenberg <lars.ellenberg@linbit.com> | 2015-02-25 19:37:28 +0100 |
|---|---|---|
| committer | Jens Axboe <axboe@fb.com> | 2015-11-25 17:22:01 +0100 |
| commit | 6434f404b43afa0cfe54fec009760510431ca103 (patch) | |
| tree | 3b5adfc83ae2fe16d028d1ec44db50bbe0cf93d1 /drivers/block/drbd/drbd_req.c | |
| parent | drbd: fix NULL deref in remember_new_state (diff) | |
| download | linux-6434f404b43afa0cfe54fec009760510431ca103.tar.xz linux-6434f404b43afa0cfe54fec009760510431ca103.zip | |
drbd: fix refcount error during detach of an already failed disk
A D_FAILED disk transitions as quickly as possible to
D_DISKLESS. But in the "unresponsive local disk" case,
there remains a time window where a administrative detach command could
find the disk already failed, but some internal meta data IO against the
unresponsive local disk still pending.
In that case, drbd_md_get_buffer() will return NULL.
Don't unconditionally call drbd_md_put_buffer(), or it will cause
refcount imbalance, and prevent any further re-attach on this volume
(until it is deleted and re-created).
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
Diffstat (limited to 'drivers/block/drbd/drbd_req.c')
0 files changed, 0 insertions, 0 deletions