diff options
| author | Alexander Gordeev <agordeev@redhat.com> | 2014-02-19 09:58:18 +0100 |
|---|---|---|
| committer | Jens Axboe <axboe@fb.com> | 2014-02-22 00:45:26 +0100 |
| commit | c5e3035c88cbefe60ec155b3f9999413da1ee694 (patch) | |
| tree | 2711267f6bc9e32ef56dc92f19b2992a09b23ea8 /drivers/block/skd_main.c | |
| parent | mtip32xx: Use pci_enable_msix_range() instead of pci_enable_msix() (diff) | |
| download | linux-c5e3035c88cbefe60ec155b3f9999413da1ee694.tar.xz linux-c5e3035c88cbefe60ec155b3f9999413da1ee694.zip | |
skd: Fix out of array boundary access
When enabling MSI-X, interrupts are requested for SKD_MAX_MSIX_COUNT
entries in skdev->msix_entries array, while the number of actually
allocated entries is skdev->msix_count. This might lead to an out of
boundary access in case number of allocated entries is less than
SKD_MAX_MSIX_COUNT. This update fixes the described misbehaviour.
Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
Cc: linux-pci@vger.kernel.org
Signed-off-by: Jens Axboe <axboe@fb.com>
Diffstat (limited to 'drivers/block/skd_main.c')
| -rw-r--r-- | drivers/block/skd_main.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c index eb6e1e0e8db2..3fa0918ddaf8 100644 --- a/drivers/block/skd_main.c +++ b/drivers/block/skd_main.c @@ -3989,7 +3989,7 @@ static int skd_acquire_msix(struct skd_device *skdev) } /* Enable MSI-X vectors for the base queue */ - for (i = 0; i < SKD_MAX_MSIX_COUNT; i++) { + for (i = 0; i < skdev->msix_count; i++) { qentry = &skdev->msix_entries[i]; snprintf(qentry->isr_name, sizeof(qentry->isr_name), "%s%d-msix %s", DRV_NAME, skdev->devno, |