diff options
| author | Keith Busch <keith.busch@intel.com> | 2014-08-27 21:55:39 +0200 |
|---|---|---|
| committer | Jens Axboe <axboe@fb.com> | 2014-11-04 21:17:09 +0100 |
| commit | 695a4fe79ffa70023238b6b2d4c20fe1a05288fb (patch) | |
| tree | c4fd6fffb45ba42442ecc7bad1113972d422b4c0 /drivers/block | |
| parent | NVMe: Remove duplicate compat SG_IO code (diff) | |
| download | linux-695a4fe79ffa70023238b6b2d4c20fe1a05288fb.tar.xz linux-695a4fe79ffa70023238b6b2d4c20fe1a05288fb.zip | |
NVMe: Fix SG_IO status values
We've only been setting the sg_io_hdr status values on SCSI commands
that require an nvme command to complete the translation. The fields
in the struct are output parameters, so we have to set them, otherwise
user space will see whatever was in memory from before. In the case of
compat SG_IO, this would reveal kernel memory. This fixes the issue by
initializing the sg_io_hdr with successful status.
Signed-off-by: Keith Busch <keith.busch@intel.com>
Acked-by: Vishal Verma <vishal.l.verma@linux.intel.com>
Signed-off-by: Matthew Wilcox <matthew.r.wilcox@intel.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
Diffstat (limited to 'drivers/block')
| -rw-r--r-- | drivers/block/nvme-scsi.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/drivers/block/nvme-scsi.c b/drivers/block/nvme-scsi.c index dabafa6a64cb..046ae3321c5e 100644 --- a/drivers/block/nvme-scsi.c +++ b/drivers/block/nvme-scsi.c @@ -2915,6 +2915,14 @@ static int nvme_scsi_translate(struct nvme_ns *ns, struct sg_io_hdr *hdr) if (copy_from_user(cmd, hdr->cmdp, hdr->cmd_len)) return -EFAULT; + /* + * Prime the hdr with good status for scsi commands that don't require + * an nvme command for translation. + */ + retcode = nvme_trans_status_code(hdr, NVME_SC_SUCCESS); + if (retcode) + return retcode; + opcode = cmd[0]; switch (opcode) { |