diff options
| author | Alex Elder <elder@inktank.com> | 2013-05-06 15:37:00 +0200 |
|---|---|---|
| committer | Alex Elder <elder@inktank.com> | 2013-05-08 14:38:30 +0200 |
| commit | 49ece554288caf1a8ea9e546ab1ff5bc4b175456 (patch) | |
| tree | 348c9a673077b2c43e07e75a12873d72a3920a29 /drivers/block | |
| parent | rbd: fix image request leak on parent read (diff) | |
| download | linux-49ece554288caf1a8ea9e546ab1ff5bc4b175456.tar.xz linux-49ece554288caf1a8ea9e546ab1ff5bc4b175456.zip | |
rbd: fix leak of format 2 snapshot context
When rbd_dev_v2_refresh() is called, the rbd device already has a
snapshot context associated with it. But that never gets freed,
the pointer just gets overwritten.
Fix this by dropping the rbd device's reference to the snapshot
context before overwriting the pointer.
Because ceph_put_snap_context() already handles for a null pointer
we don't need to check for that (for the probe case, where no
context has yet been assigned).
This resolves:
http://tracker.ceph.com/issues/4912
Signed-off-by: Alex Elder <elder@inktank.com>
Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
Diffstat (limited to 'drivers/block')
| -rw-r--r-- | drivers/block/rbd.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c index c2ca1818f335..426374321d75 100644 --- a/drivers/block/rbd.c +++ b/drivers/block/rbd.c @@ -4004,6 +4004,7 @@ static int rbd_dev_v2_snap_context(struct rbd_device *rbd_dev) for (i = 0; i < snap_count; i++) snapc->snaps[i] = ceph_decode_64(&p); + ceph_put_snap_context(rbd_dev->header.snapc); rbd_dev->header.snapc = snapc; dout(" snap context seq = %llu, snap_count = %u\n", |