diff options
| author | Julia Lawall <julia@diku.dk> | 2009-12-27 22:27:11 +0100 |
|---|---|---|
| committer | Philipp Reisner <philipp.reisner@linbit.com> | 2010-01-04 11:51:41 +0100 |
| commit | 2d1ee87d8763b38668f6f11bb53abb689a49a43e (patch) | |
| tree | 3a87ab8e3339a64d5f4c13938e1234f0b07a19dd /drivers/block | |
| parent | Merge branch 'for-jens' of git://git.drbd.org/linux-2.6-drbd into for-linus (diff) | |
| download | linux-2d1ee87d8763b38668f6f11bb53abb689a49a43e.tar.xz linux-2d1ee87d8763b38668f6f11bb53abb689a49a43e.zip | |
drivers/block/drbd: Correct NULL test
Test the just-allocated value for NULL rather than some other value.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression x,y;
statement S;
@@
x = \(kmalloc\|kcalloc\|kzalloc\)(...);
(
if ((x) == NULL) S
|
if (
- y
+ x
== NULL)
S
)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Diffstat (limited to 'drivers/block')
| -rw-r--r-- | drivers/block/drbd/drbd_receiver.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c index a6d266ee7e2a..dbd451984e0d 100644 --- a/drivers/block/drbd/drbd_receiver.c +++ b/drivers/block/drbd/drbd_receiver.c @@ -3945,7 +3945,7 @@ static int drbd_do_auth(struct drbd_conf *mdev) } right_response = kmalloc(resp_size, GFP_NOIO); - if (response == NULL) { + if (right_response == NULL) { dev_err(DEV, "kmalloc of right_response failed\n"); rv = 0; goto fail; |