diff options
| author | Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com> | 2009-06-10 06:38:38 +0200 |
|---|---|---|
| committer | Benjamin Herrenschmidt <benh@kernel.crashing.org> | 2009-06-15 05:26:18 +0200 |
| commit | 3c20e2f2793380add92dacce63395a8503b6c7c9 (patch) | |
| tree | 6e4c10bf5162b0c9a479bc3180dc2cd59040409a /drivers/block | |
| parent | ps3vram: Fix error path (return -EIO) for short read/write (diff) | |
| download | linux-3c20e2f2793380add92dacce63395a8503b6c7c9.tar.xz linux-3c20e2f2793380add92dacce63395a8503b6c7c9.zip | |
ps3vram: Use proc_create_data() instead of proc_create()
Use proc_create_data() to avoid race conditions.
Reported-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Cc: Jim Paris <jim@jtan.com>
Cc: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Diffstat (limited to 'drivers/block')
| -rw-r--r-- | drivers/block/ps3vram.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/drivers/block/ps3vram.c b/drivers/block/ps3vram.c index 2e79d2cfa023..6e738684a158 100644 --- a/drivers/block/ps3vram.c +++ b/drivers/block/ps3vram.c @@ -546,12 +546,10 @@ static void __devinit ps3vram_proc_init(struct ps3_system_bus_device *dev) struct ps3vram_priv *priv = dev->core.driver_data; struct proc_dir_entry *pde; - pde = proc_create(DEVICE_NAME, 0444, NULL, &ps3vram_proc_fops); - if (!pde) { + pde = proc_create_data(DEVICE_NAME, 0444, NULL, &ps3vram_proc_fops, + priv); + if (!pde) dev_warn(&dev->core, "failed to create /proc entry\n"); - return; - } - pde->data = priv; } static int ps3vram_make_request(struct request_queue *q, struct bio *bio) |