diff options
| author | Colin Ian King <colin.king@canonical.com> | 2019-11-29 18:36:35 +0100 |
|---|---|---|
| committer | Marcel Holtmann <marcel@holtmann.org> | 2019-11-29 20:21:33 +0100 |
| commit | 3168c19d7eb17a0108a3b60ad8e8c1b18ea05c63 (patch) | |
| tree | f53b6a2d7e9cc803887c6ae14881ee474cb8c51d /drivers/bluetooth | |
| parent | Bluetooth: btusb: fix non-atomic allocation in completion handler (diff) | |
| download | linux-3168c19d7eb17a0108a3b60ad8e8c1b18ea05c63.tar.xz linux-3168c19d7eb17a0108a3b60ad8e8c1b18ea05c63.zip | |
Bluetooth: btusb: fix memory leak on fw
Currently the error return path when the call to btusb_mtk_hci_wmt_sync
fails does not free fw. Fix this by returning via the error_release_fw
label that performs the free'ing.
Addresses-Coverity: ("Resource leak")
Fixes: a1c49c434e15 ("Bluetooth: btusb: Add protocol support for MediaTek MT7668U USB devices")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Diffstat (limited to 'drivers/bluetooth')
| -rw-r--r-- | drivers/bluetooth/btusb.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index 9b587e662b48..d9cd0677d41c 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -2867,7 +2867,7 @@ static int btusb_mtk_setup_firmware(struct hci_dev *hdev, const char *fwname) err = btusb_mtk_hci_wmt_sync(hdev, &wmt_params); if (err < 0) { bt_dev_err(hdev, "Failed to send wmt rst (%d)", err); - return err; + goto err_release_fw; } /* Wait a few moments for firmware activation done */ |