summaryrefslogtreecommitdiffstats
path: root/drivers/bluetooth
diff options
context:
space:
mode:
authorLoic Poulain <loic.poulain@intel.com>2017-06-27 19:15:07 +0200
committerMarcel Holtmann <marcel@holtmann.org>2017-06-27 19:28:11 +0200
commitcdd24a200a8fa39e383890bbf862c0aa83ba83f5 (patch)
tree0e4a4176f854f33c0c39cec9c7fdb85cf38396f3 /drivers/bluetooth
parentBluetooth: hci_serdev: make hci_serdev_client_ops static (diff)
downloadlinux-cdd24a200a8fa39e383890bbf862c0aa83ba83f5.tar.xz
linux-cdd24a200a8fa39e383890bbf862c0aa83ba83f5.zip
Bluetooth: hci_bcm: Fix unwanted error reporting if no bcm dev
The hci_bcm proto is able to operate without bcm platform device linked to its uart port. In that case, firmware can be applied, but there is no power operation (no gpio/irq resources mgmt). However, the current implementation breaks this use case because of reporting a ENODEV error in the bcm setup procedure if bcm_request_irq fails (which is the case if no bcm device linked). Fix this by removing bcm_request_irq error forwarding. Signed-off-by: Loic Poulain <loic.poulain@intel.com> Reported-by: Ian Molton <ian@mnementh.co.uk> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Diffstat (limited to 'drivers/bluetooth')
-rw-r--r--drivers/bluetooth/hci_bcm.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/bluetooth/hci_bcm.c b/drivers/bluetooth/hci_bcm.c
index d2e9e2d1b014..192ad2781733 100644
--- a/drivers/bluetooth/hci_bcm.c
+++ b/drivers/bluetooth/hci_bcm.c
@@ -419,8 +419,7 @@ finalize:
if (err)
return err;
- err = bcm_request_irq(bcm);
- if (!err)
+ if (!bcm_request_irq(bcm))
err = bcm_setup_sleep(hu);
return err;