summaryrefslogtreecommitdiffstats
path: root/drivers/char/agp/Makefile
diff options
context:
space:
mode:
authorDaniel Vetter <daniel.vetter@ffwll.ch>2020-11-17 22:40:29 +0100
committerDaniel Vetter <daniel.vetter@ffwll.ch>2020-11-18 22:47:45 +0100
commitf9f92e7c583f9b120bbb09edae6a587b73feb3a9 (patch)
treeffdca977a8b38e5f57b6f537c05e42dfa424228c /drivers/char/agp/Makefile
parentdrm/via: fix assignment in if condition (diff)
downloadlinux-f9f92e7c583f9b120bbb09edae6a587b73feb3a9.tar.xz
linux-f9f92e7c583f9b120bbb09edae6a587b73feb3a9.zip
char/agp: Disable frontend without CONFIG_DRM_LEGACY
It's probably full of bugs ready for exploiting by userspace. And there's not going to be any userspace for this without any of the drm legacy drivers enabled too. So just couple it together. Note that the frontend is only the /dev/agp ioctl interface, which per Adam is only used by the i810 userspace drivers. All other drivers go through the drm bufmap agp handling abstraction apparently. v2: Augment commit message a bit from m-l feedback. Acked-by: Adam Jackson <ajax@redhat.com> Acked-by: Christian König <christian.koenig@amd.com> Acked-by: Thomas Zimmermann <tzimmermann@suse.de> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Cc: David Airlie <airlied@linux.ie> Cc: Adam Jackson <ajax@redhat.com> Link: https://patchwork.freedesktop.org/patch/msgid/20201117214029.591896-1-daniel.vetter@ffwll.ch
Diffstat (limited to 'drivers/char/agp/Makefile')
-rw-r--r--drivers/char/agp/Makefile6
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/char/agp/Makefile b/drivers/char/agp/Makefile
index cb2497d157f6..90ed8c789e48 100644
--- a/drivers/char/agp/Makefile
+++ b/drivers/char/agp/Makefile
@@ -1,7 +1,11 @@
# SPDX-License-Identifier: GPL-2.0
-agpgart-y := backend.o frontend.o generic.o isoch.o
+agpgart-y := backend.o generic.o isoch.o
+ifeq ($(CONFIG_DRM_LEGACY),y)
agpgart-$(CONFIG_COMPAT) += compat_ioctl.o
+agpgart-y += frontend.o
+endif
+
obj-$(CONFIG_AGP) += agpgart.o
obj-$(CONFIG_AGP_ALI) += ali-agp.o