diff options
| author | Jan Beulich <jbeulich@novell.com> | 2008-06-18 10:28:00 +0200 |
|---|---|---|
| committer | Dave Airlie <airlied@redhat.com> | 2008-06-19 01:56:16 +0200 |
| commit | da503fa60b84d5945deb3ab74efdd0bec61df4a1 (patch) | |
| tree | 9883d28cabdab419567a2c0689d06c938460eaa1 /drivers/char/agp/hp-agp.c | |
| parent | agp/via: fixup pci ids (diff) | |
| download | linux-da503fa60b84d5945deb3ab74efdd0bec61df4a1.tar.xz linux-da503fa60b84d5945deb3ab74efdd0bec61df4a1.zip | |
agp: two-stage page destruction issue
besides it apparently being useful only in 2.6.24 (the changes in 2.6.25
really mean that it could be converted back to a single-stage mechanism),
I'm seeing an issue in Xen Dom0 kernels, which is caused by the calling
of gart_to_virt() in the second stage invocations of the destroy function.
I think that besides this being a real issue with Xen (where
unmap_page_from_agp() is not just a page table attribute change), this
also is invalid from a theoretical perspective: One should not assume that
gart_to_virt() is still valid after unmapping a page. So minimally (keeping
the 2-stage mechanism) a patch like the one below would be needed.
Jan
Signed-off-by: Dave Airlie <airlied@redhat.com>
Diffstat (limited to 'drivers/char/agp/hp-agp.c')
0 files changed, 0 insertions, 0 deletions