diff options
| author | Harvey Harrison <harvey.harrison@gmail.com> | 2008-04-30 09:53:50 +0200 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-04-30 17:29:44 +0200 |
| commit | f5592268a5aa5e02f36f396de47c94a1506e3678 (patch) | |
| tree | 1c5d4b301928cbfd55ebf57e0808c95d2615f6aa /drivers/char/esp.c | |
| parent | Char: moxa, add firmware loading fix (diff) | |
| download | linux-f5592268a5aa5e02f36f396de47c94a1506e3678.tar.xz linux-f5592268a5aa5e02f36f396de47c94a1506e3678.zip | |
char: fix sparse shadowed variable warnings in esp.c
flags only use was in spin_lock_irqsave/spin_lock_irgrestore pairs, no
need to redeclare for each one.
drivers/char/esp.c:1599:17: warning: symbol 'flags' shadows an earlier one
drivers/char/esp.c:1517:16: originally declared here
drivers/char/esp.c:1615:17: warning: symbol 'flags' shadows an earlier one
drivers/char/esp.c:1517:16: originally declared here
drivers/char/esp.c:1631:17: warning: symbol 'flags' shadows an earlier one
drivers/char/esp.c:1517:16: originally declared here
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to '')
| -rw-r--r-- | drivers/char/esp.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/drivers/char/esp.c b/drivers/char/esp.c index 5ad11a6716c7..763d6d2e4b62 100644 --- a/drivers/char/esp.c +++ b/drivers/char/esp.c @@ -1600,8 +1600,6 @@ static int set_esp_config(struct esp_struct * info, if ((new_config.flow_off != info->config.flow_off) || (new_config.flow_on != info->config.flow_on)) { - unsigned long flags; - info->config.flow_off = new_config.flow_off; info->config.flow_on = new_config.flow_on; @@ -1616,8 +1614,6 @@ static int set_esp_config(struct esp_struct * info, if ((new_config.rx_trigger != info->config.rx_trigger) || (new_config.tx_trigger != info->config.tx_trigger)) { - unsigned long flags; - info->config.rx_trigger = new_config.rx_trigger; info->config.tx_trigger = new_config.tx_trigger; spin_lock_irqsave(&info->lock, flags); @@ -1632,8 +1628,6 @@ static int set_esp_config(struct esp_struct * info, } if (new_config.rx_timeout != info->config.rx_timeout) { - unsigned long flags; - info->config.rx_timeout = new_config.rx_timeout; spin_lock_irqsave(&info->lock, flags); |