diff options
| author | Martin Kaiser <martin@kaiser.cx> | 2020-03-05 21:58:20 +0100 |
|---|---|---|
| committer | Herbert Xu <herbert@gondor.apana.org.au> | 2020-03-12 13:00:15 +0100 |
| commit | 47a1f8e8b3637ff5f7806587883d7d94068d9ee8 (patch) | |
| tree | ec0e231ff2a219198504f98a1c1a682acd9558e6 /drivers/char/hw_random | |
| parent | hwrng: ks-sa - move TI Keystone driver into the config menu structure (diff) | |
| download | linux-47a1f8e8b3637ff5f7806587883d7d94068d9ee8.tar.xz linux-47a1f8e8b3637ff5f7806587883d7d94068d9ee8.zip | |
hwrng: imx-rngc - fix an error path
Make sure that the rngc interrupt is masked if the rngc self test fails.
Self test failure means that probe fails as well. Interrupts should be
masked in this case, regardless of the error.
Cc: stable@vger.kernel.org
Fixes: 1d5449445bd0 ("hwrng: mx-rngc - add a driver for Freescale RNGC")
Reviewed-by: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'drivers/char/hw_random')
| -rw-r--r-- | drivers/char/hw_random/imx-rngc.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/char/hw_random/imx-rngc.c b/drivers/char/hw_random/imx-rngc.c index 30cf00f8e9a0..0576801944fd 100644 --- a/drivers/char/hw_random/imx-rngc.c +++ b/drivers/char/hw_random/imx-rngc.c @@ -105,8 +105,10 @@ static int imx_rngc_self_test(struct imx_rngc *rngc) return -ETIMEDOUT; } - if (rngc->err_reg != 0) + if (rngc->err_reg != 0) { + imx_rngc_irq_mask_clear(rngc); return -EIO; + } return 0; } |