diff options
| author | Jiri Slaby <jirislaby@gmail.com> | 2009-04-06 18:34:10 +0200 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2009-04-06 23:36:33 +0200 |
| commit | 0326e6d596491db64d787136cbd703bde0ee8d77 (patch) | |
| tree | 4eca69db77dbfd32d1b59dc2239f65046c8aa3ae /drivers/char/mxser.c | |
| parent | tty: moxa, fix refcounting in moxa_poll_port (diff) | |
| download | linux-0326e6d596491db64d787136cbd703bde0ee8d77.tar.xz linux-0326e6d596491db64d787136cbd703bde0ee8d77.zip | |
mxser: remove tty_port_tty_get from mxser_check_modem_status
mxser_check_modem_status is called with tty parameter, so the
reference should be increased by callers already -- for ioctl
syscall it is held whole time gap since open to close, for
interrupt, the reference count is increased in the irq handler.
There is no tty_kref_put in that function, so this also fixes
a refcounting bug.
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: Alan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to '')
| -rw-r--r-- | drivers/char/mxser.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/char/mxser.c b/drivers/char/mxser.c index 402c9f217f83..a420e8d437dd 100644 --- a/drivers/char/mxser.c +++ b/drivers/char/mxser.c @@ -820,7 +820,6 @@ static void mxser_check_modem_status(struct tty_struct *tty, wake_up_interruptible(&port->port.open_wait); } - tty = tty_port_tty_get(&port->port); if (port->port.flags & ASYNC_CTS_FLOW) { if (tty->hw_stopped) { if (status & UART_MSR_CTS) { |