diff options
| author | Vasiliy Kulikov <segooon@gmail.com> | 2010-10-17 16:41:24 +0200 |
|---|---|---|
| committer | Dominik Brodowski <linux@dominikbrodowski.net> | 2010-10-21 17:29:23 +0200 |
| commit | 5b917a1420d3d1a9c8da49fb0090692dc9aaee86 (patch) | |
| tree | 930439eff752e5aababfed19cf4bc5b5be65353d /drivers/char/pcmcia/synclink_cs.c | |
| parent | pcmcia: don't call flush_scheduled_work() spuriously (diff) | |
| download | linux-5b917a1420d3d1a9c8da49fb0090692dc9aaee86.tar.xz linux-5b917a1420d3d1a9c8da49fb0090692dc9aaee86.zip | |
pcmcia: synclink_cs: fix information leak to userland
Structure new_line is copied to userland with some padding fields unitialized.
It leads to leaking of stack memory.
Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
CC: stable@kernel.org
Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
Diffstat (limited to 'drivers/char/pcmcia/synclink_cs.c')
| -rw-r--r-- | drivers/char/pcmcia/synclink_cs.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/char/pcmcia/synclink_cs.c b/drivers/char/pcmcia/synclink_cs.c index d97a53cccdc5..be1810057607 100644 --- a/drivers/char/pcmcia/synclink_cs.c +++ b/drivers/char/pcmcia/synclink_cs.c @@ -4097,6 +4097,8 @@ static int hdlcdev_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) if (cmd != SIOCWANDEV) return hdlc_ioctl(dev, ifr, cmd); + memset(&new_line, 0, size); + switch(ifr->ifr_settings.type) { case IF_GET_IFACE: /* return current sync_serial_settings */ |