diff options
| author | Amit Shah <amit.shah@redhat.com> | 2011-03-14 13:15:48 +0100 |
|---|---|---|
| committer | Rusty Russell <rusty@rustcorp.com.au> | 2011-04-21 15:27:00 +0200 |
| commit | afa2689e19073cd2e762d0f2c1358fab1ab9f18c (patch) | |
| tree | 54e454f26327da2063af856bc7863bf7ea8e7b62 /drivers/char/virtio_console.c | |
| parent | virtio_pci: Prevent double-free of pci regions after device hot-unplug (diff) | |
| download | linux-afa2689e19073cd2e762d0f2c1358fab1ab9f18c.tar.xz linux-afa2689e19073cd2e762d0f2c1358fab1ab9f18c.zip | |
virtio: console: Enable call to hvc_remove() on console port remove
This call was disabled as hot-unplugging one virtconsole port led to
another virtconsole port freezing.
Upon testing it again, this now works, so enable it.
In addition, a bug was found in qemu wherein removing a port of one type
caused the guest output from another port to stop working. I doubt it
was just this bug that caused it (since disabling the hvc_remove() call
did allow other ports to continue working), but since it's all solved
now, we're fine with hot-unplugging of virtconsole ports.
Signed-off-by: Amit Shah <amit.shah@redhat.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Diffstat (limited to '')
| -rw-r--r-- | drivers/char/virtio_console.c | 11 |
1 files changed, 0 insertions, 11 deletions
diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c index 84b164d1eb2b..838568a7dbf5 100644 --- a/drivers/char/virtio_console.c +++ b/drivers/char/virtio_console.c @@ -1280,18 +1280,7 @@ static void unplug_port(struct port *port) spin_lock_irq(&pdrvdata_lock); list_del(&port->cons.list); spin_unlock_irq(&pdrvdata_lock); -#if 0 - /* - * hvc_remove() not called as removing one hvc port - * results in other hvc ports getting frozen. - * - * Once this is resolved in hvc, this functionality - * will be enabled. Till that is done, the -EPIPE - * return from get_chars() above will help - * hvc_console.c to clean up on ports we remove here. - */ hvc_remove(port->cons.hvc); -#endif } /* Remove unused data this port might have received. */ |