summaryrefslogtreecommitdiffstats
path: root/drivers/char
diff options
context:
space:
mode:
authorJani Nikula <ext-jani.1.nikula@nokia.com>2010-03-11 17:15:53 +0100
committerJiri Kosina <jkosina@suse.cz>2010-03-15 15:31:04 +0100
commit30c96ce56a195963764de9521087202ba73e9bff (patch)
treed2efc82338c0efea307cf9cb5a1cf10f218d4e26 /drivers/char
parentkobj: add comment and multiple inclusion protection (diff)
downloadlinux-30c96ce56a195963764de9521087202ba73e9bff.tar.xz
linux-30c96ce56a195963764de9521087202ba73e9bff.zip
powerpc/BSR: fix device_create() return value check
Use IS_ERR() instead of comparing to NULL. Signed-off-by: Jani Nikula <ext-jani.1.nikula@nokia.com> Acked-by: Sonny Rao <sonnyrao@us.ibm.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/char')
-rw-r--r--drivers/char/bsr.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/char/bsr.c b/drivers/char/bsr.c
index c02db01f736e..3b31f744b7af 100644
--- a/drivers/char/bsr.c
+++ b/drivers/char/bsr.c
@@ -252,7 +252,7 @@ static int bsr_add_node(struct device_node *bn)
cur->bsr_device = device_create(bsr_class, NULL, cur->bsr_dev,
cur, cur->bsr_name);
- if (!cur->bsr_device) {
+ if (IS_ERR(cur->bsr_device)) {
printk(KERN_ERR "device_create failed for %s\n",
cur->bsr_name);
cdev_del(&cur->bsr_cdev);