diff options
| author | Colin Ian King <colin.king@canonical.com> | 2017-05-07 20:05:16 +0200 |
|---|---|---|
| committer | Corey Minyard <cminyard@mvista.com> | 2017-05-18 01:30:35 +0200 |
| commit | bf10ff69dd6e27710b21863ebd8e6504d9516222 (patch) | |
| tree | bf9dd29df979103926dfb93dcfae251fe491e0da /drivers/char | |
| parent | ipmi/watchdog: fix watchdog timeout set on reboot (diff) | |
| download | linux-bf10ff69dd6e27710b21863ebd8e6504d9516222.tar.xz linux-bf10ff69dd6e27710b21863ebd8e6504d9516222.zip | |
ipmi_ssif: remove redundant null check on array client->adapter->name
The null check on client->adapter->name is redundant as name is an
array of I2C_NAME_SIZE chars and hence can never be null. We may as
well remove this redundant check.
Detected by CoverityScan, CID#1375918 ("Array compared against 0")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
Diffstat (limited to 'drivers/char')
| -rw-r--r-- | drivers/char/ipmi/ipmi_ssif.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c index 6dd6476ea5d3..1d4fd846e457 100644 --- a/drivers/char/ipmi/ipmi_ssif.c +++ b/drivers/char/ipmi/ipmi_ssif.c @@ -1419,8 +1419,7 @@ static int find_slave_address(struct i2c_client *client, int slave_addr) list_for_each_entry(info, &ssif_infos, link) { if (info->binfo.addr != client->addr) continue; - if (info->adapter_name && client->adapter->name && - strcmp_nospace(info->adapter_name, + if (info->adapter_name && strcmp_nospace(info->adapter_name, client->adapter->name)) continue; if (info->slave_addr) { |