diff options
| author | Corey Minyard <cminyard@mvista.com> | 2017-06-30 14:18:08 +0200 |
|---|---|---|
| committer | Corey Minyard <cminyard@mvista.com> | 2017-06-30 14:18:08 +0200 |
| commit | 4495ec6d770e1bca7a04e93ac453ab6720c56c5d (patch) | |
| tree | ac17ad2bded1808cc9a5eed5680b5266b8f7d54d /drivers/char | |
| parent | char: ipmi: constify bmc_dev_attr_group and bmc_device_type (diff) | |
| download | linux-4495ec6d770e1bca7a04e93ac453ab6720c56c5d.tar.xz linux-4495ec6d770e1bca7a04e93ac453ab6720c56c5d.zip | |
ipmi:ssif: Add missing unlock in error branch
When getting flags, a response to a different message would
result in a deadlock because of a missing unlock. Add that
unlock and a comment. Found by static analysis.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: stable@vger.kernel.org # 3.19
Signed-off-by: Corey Minyard <cminyard@mvista.com>
Diffstat (limited to 'drivers/char')
| -rw-r--r-- | drivers/char/ipmi/ipmi_ssif.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c index 971ecda33657..0aea3bcb6158 100644 --- a/drivers/char/ipmi/ipmi_ssif.c +++ b/drivers/char/ipmi/ipmi_ssif.c @@ -766,6 +766,11 @@ static void msg_done_handler(struct ssif_info *ssif_info, int result, result, len, data[2]); } else if (data[0] != (IPMI_NETFN_APP_REQUEST | 1) << 2 || data[1] != IPMI_GET_MSG_FLAGS_CMD) { + /* + * Don't abort here, maybe it was a queued + * response to a previous command. + */ + ipmi_ssif_unlock_cond(ssif_info, flags); pr_warn(PFX "Invalid response getting flags: %x %x\n", data[0], data[1]); } else { |