diff options
| author | Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com> | 2015-04-23 04:16:44 +0200 |
|---|---|---|
| committer | Corey Minyard <cminyard@mvista.com> | 2015-05-06 02:33:49 +0200 |
| commit | 9f8127048ab8b47b43f8aeaaec9fec2da44be9a1 (patch) | |
| tree | ded69906802d1151af32d5e1f150f87306d6127b /drivers/char | |
| parent | ipmi: Report an error if ACPI _IFT doesn't exist (diff) | |
| download | linux-9f8127048ab8b47b43f8aeaaec9fec2da44be9a1.tar.xz linux-9f8127048ab8b47b43f8aeaaec9fec2da44be9a1.zip | |
ipmi: Fix a problem that messages are not issued in run_to_completion mode
start_next_msg() issues a message placed in smi_info->waiting_msg
if it is non-NULL. However, sender() sets a message to
smi_info->curr_msg and NULL to smi_info->waiting_msg in the context
of run_to_completion mode. As the result, it leads an infinite
loop by waiting the completion of unissued message when leaving
dying message after kernel panic.
sender() should set the message to smi_info->waiting_msg not
curr_msg.
Signed-off-by: Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
Diffstat (limited to 'drivers/char')
| -rw-r--r-- | drivers/char/ipmi/ipmi_si_intf.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c index b5a1b450471f..8a45e92ff60c 100644 --- a/drivers/char/ipmi/ipmi_si_intf.c +++ b/drivers/char/ipmi/ipmi_si_intf.c @@ -942,8 +942,7 @@ static void sender(void *send_info, * If we are running to completion, start it and run * transactions until everything is clear. */ - smi_info->curr_msg = msg; - smi_info->waiting_msg = NULL; + smi_info->waiting_msg = msg; /* * Run to completion means we are single-threaded, no |