summaryrefslogtreecommitdiffstats
path: root/drivers/char
diff options
context:
space:
mode:
authorMarkus Elfring <elfring@users.sourceforge.net>2015-06-27 18:12:14 +0200
committerCorey Minyard <cminyard@mvista.com>2015-09-03 22:02:25 +0200
commita7930899ca0082a33350b253c6ed34f67255f98e (patch)
treeaf9694080651d95823953b29d4a14a32ff65f5dd /drivers/char
parentchar:ipmi - Change 1 to true for bool type variables during initialization. (diff)
downloadlinux-a7930899ca0082a33350b253c6ed34f67255f98e.tar.xz
linux-a7930899ca0082a33350b253c6ed34f67255f98e.zip
ipmi: Delete an unnecessary check before the function call "cleanup_one_si"
The cleanup_one_si() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Signed-off-by: Corey Minyard <cminyard@mvista.com>
Diffstat (limited to 'drivers/char')
-rw-r--r--drivers/char/ipmi/ipmi_si_intf.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
index b1fdbf78da9b..4387bd6de2ca 100644
--- a/drivers/char/ipmi/ipmi_si_intf.c
+++ b/drivers/char/ipmi/ipmi_si_intf.c
@@ -2775,9 +2775,7 @@ static int ipmi_remove(struct platform_device *dev)
{
struct smi_info *info = dev_get_drvdata(&dev->dev);
- if (info)
- cleanup_one_si(info);
-
+ cleanup_one_si(info);
return 0;
}