summaryrefslogtreecommitdiffstats
path: root/drivers/clk/clk-cdce925.c
diff options
context:
space:
mode:
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>2016-11-11 22:49:05 +0100
committerStephen Boyd <sboyd@codeaurora.org>2016-12-09 01:29:36 +0100
commit5785271ef2bb9ca37ba1b40ec56b8d127caf3b2c (patch)
tree6c908df249f189f86c7045a8dd3eeccb1f067abe /drivers/clk/clk-cdce925.c
parentclk: bcm: Make COMMON_CLK_IPROC into a library (diff)
downloadlinux-5785271ef2bb9ca37ba1b40ec56b8d127caf3b2c.tar.xz
linux-5785271ef2bb9ca37ba1b40ec56b8d127caf3b2c.zip
clk: cdce925: Fix limit check
It is likely that instead of '1>64', 'q>64' was expected. Moreover, according to datasheet, http://www.ti.com/lit/ds/symlink/cdce925.pdf SCAS847I - JULY 2007 - REVISED OCTOBER 2016 PLL settings limits are: 16 <= q <= 63 So change the upper limit check from 64 to 63. Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Diffstat (limited to 'drivers/clk/clk-cdce925.c')
-rw-r--r--drivers/clk/clk-cdce925.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/clk/clk-cdce925.c b/drivers/clk/clk-cdce925.c
index b8459c14a1b7..f793b2d9238c 100644
--- a/drivers/clk/clk-cdce925.c
+++ b/drivers/clk/clk-cdce925.c
@@ -216,7 +216,7 @@ static int cdce925_pll_prepare(struct clk_hw *hw)
nn = n * BIT(p);
/* q = int(nn/m) */
q = nn / m;
- if ((q < 16) || (1 > 64)) {
+ if ((q < 16) || (q > 63)) {
pr_debug("%s invalid q=%d\n", __func__, q);
return -EINVAL;
}