summaryrefslogtreecommitdiffstats
path: root/drivers/clk/clk-si5351.c
diff options
context:
space:
mode:
authorJulia Lawall <Julia.Lawall@lip6.fr>2015-10-21 22:41:36 +0200
committerStephen Boyd <sboyd@codeaurora.org>2015-10-22 01:16:32 +0200
commit6bc9d9d62cbc885414c7d4bb1926c43950498479 (patch)
tree41e406b11eda8c306e1d272e90e324835ab285f6 /drivers/clk/clk-si5351.c
parentclk: iproc: Fix PLL output frequency calculation (diff)
downloadlinux-6bc9d9d62cbc885414c7d4bb1926c43950498479.tar.xz
linux-6bc9d9d62cbc885414c7d4bb1926c43950498479.zip
clk: add missing of_node_put
for_each_matching_node_and_match performs an of_node_get on each iteration, so a break out of the loop requires an of_node_put. A simplified version of the semantic patch that fixes this problem is as follows (http://coccinelle.lip6.fr): // <smpl> @@ expression e1,e2,e; local idexpression np; @@ for_each_matching_node_and_match(np, e1, e2) { ... when != of_node_put(np) when != e = np ( return np; | + of_node_put(np); ? return ...; ) ... } // </smpl> Besides the problem identified by the semantic patch, this patch adds an of_node_get in front of saving np in a field of parent, to account for the fact that this value will be put on going on to the next element in the iteration, and then adds of_node_puts in the two loops where the parent pointer can be freed. Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Diffstat (limited to 'drivers/clk/clk-si5351.c')
0 files changed, 0 insertions, 0 deletions