diff options
| author | Wei Yongjun <weiyongjun1@huawei.com> | 2018-03-20 15:19:34 +0100 |
|---|---|---|
| committer | Stephen Boyd <sboyd@kernel.org> | 2018-03-20 18:23:41 +0100 |
| commit | c744b63b6c422776293cc526ef7887623926f33e (patch) | |
| tree | a938b855ef452ca0f3c2ce07572d4de61d158b35 /drivers/clk/hisilicon | |
| parent | clk: hisilicon: mark wdt_mux_p[] as const (diff) | |
| download | linux-c744b63b6c422776293cc526ef7887623926f33e.tar.xz linux-c744b63b6c422776293cc526ef7887623926f33e.zip | |
clk: hisilicon: fix potential NULL dereference in hisi_clk_alloc()
platform_get_resource() may fail and return NULL, so we should
better check it's return value to avoid a NULL pointer dereference
a bit later in the code.
This is detected by Coccinelle semantic patch.
@@
expression pdev, res, n, t, e, e1, e2;
@@
res = platform_get_resource(pdev, t, n);
+ if (!res)
+ return -EINVAL;
... when != res == NULL
e = devm_ioremap(e1, res->start, e2);
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Fixes: 322269163a36 ("clk: hisilicon: add hisi_clk_alloc function.")
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Diffstat (limited to 'drivers/clk/hisilicon')
| -rw-r--r-- | drivers/clk/hisilicon/clk.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/clk/hisilicon/clk.c b/drivers/clk/hisilicon/clk.c index 29046b8334c2..953c8dacef8b 100644 --- a/drivers/clk/hisilicon/clk.c +++ b/drivers/clk/hisilicon/clk.c @@ -49,6 +49,8 @@ struct hisi_clock_data *hisi_clk_alloc(struct platform_device *pdev, return NULL; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + if (!res) + return NULL; clk_data->base = devm_ioremap(&pdev->dev, res->start, resource_size(res)); if (!clk_data->base) |